From 6b2ca1d2e159d40239c6fda7eefd0590f1b472c9 Mon Sep 17 00:00:00 2001
From: Yohann D'ANELLO <ynerant@crans.org>
Date: Sun, 4 Apr 2021 13:30:02 +0200
Subject: [PATCH] Admin can see note details

---
 .../participation/passage_detail.html         | 32 +++++++++++--------
 apps/participation/views.py                   |  2 ++
 2 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/apps/participation/templates/participation/passage_detail.html b/apps/participation/templates/participation/passage_detail.html
index 6a64cb5..de1287e 100644
--- a/apps/participation/templates/participation/passage_detail.html
+++ b/apps/participation/templates/participation/passage_detail.html
@@ -41,9 +41,11 @@
                 </dd>
             </dl>
         </div>
-        {% if user.registration.is_admin %}
+        {% if notes is not None %}
             <div class="card-footer text-center">
-                <button class="btn btn-info" data-toggle="modal" data-target="#updateNotesModal">{% trans "Update notes" %}</button>
+                {% if my_note is not None %}
+                    <button class="btn btn-info" data-toggle="modal" data-target="#updateNotesModal">{% trans "Update notes" %}</button>
+                {% endif %}
                 <button class="btn btn-primary" data-toggle="modal" data-target="#updatePassageModal">{% trans "Update" %}</button>
             </div>
         {% elif user.registration.participates %}
@@ -98,16 +100,18 @@
         </div>
     {% endif %}
 
-    {% if user.registration.is_admin %}
+    {% if notes is not None %}
         {% trans "Update passage" as modal_title %}
         {% trans "Update" as modal_button %}
         {% url "participation:passage_update" pk=passage.pk as modal_action %}
         {% include "base_modal.html" with modal_id="updatePassage" %}
 
-        {% trans "Update notes" as modal_title %}
-        {% trans "Update" as modal_button %}
-        {% url "participation:update_notes" pk=my_note.pk as modal_action %}
-        {% include "base_modal.html" with modal_id="updateNotes" %}
+        {% if my_note is not None %}
+            {% trans "Update notes" as modal_title %}
+            {% trans "Update" as modal_button %}
+            {% url "participation:update_notes" pk=my_note.pk as modal_action %}
+            {% include "base_modal.html" with modal_id="updateNotes" %}
+        {% endif %}
     {% elif user.registration.participates %}
         {% trans "Upload synthesis" as modal_title %}
         {% trans "Upload" as modal_button %}
@@ -119,18 +123,20 @@
 {% block extrajavascript %}
     <script>
         $(document).ready(function () {
-            {% if user.registration.is_admin %}
+            {% if notes is not None %}
                 $('button[data-target="#updatePassageModal"]').click(function() {
                     let modalBody = $("#updatePassageModal div.modal-body");
                     if (!modalBody.html().trim())
                         modalBody.load("{% url "participation:passage_update" pk=passage.pk %} #form-content")
                 });
 
-                $('button[data-target="#updateNotesModal"]').click(function() {
-                    let modalBody = $("#updateNotesModal div.modal-body");
-                    if (!modalBody.html().trim())
-                        modalBody.load("{% url "participation:update_notes" pk=my_note.pk %} #form-content")
-                });
+                {% if my_note is not None %}
+                    $('button[data-target="#updateNotesModal"]').click(function() {
+                        let modalBody = $("#updateNotesModal div.modal-body");
+                        if (!modalBody.html().trim())
+                            modalBody.load("{% url "participation:update_notes" pk=my_note.pk %} #form-content")
+                    });
+                {% endif %}
             {% elif user.registration.participates %}
                 $('button[data-target="#uploadSynthesisModal"]').click(function() {
                     let modalBody = $("#uploadSynthesisModal div.modal-body");
diff --git a/apps/participation/views.py b/apps/participation/views.py
index c85a909..e0ce1c3 100644
--- a/apps/participation/views.py
+++ b/apps/participation/views.py
@@ -704,6 +704,8 @@ class PassageDetailView(LoginRequiredMixin, DetailView):
         if self.request.user.registration in self.object.pool.juries.all():
             context["my_note"] = Note.objects.get(passage=self.object, jury=self.request.user.registration)
             context["notes"] = NoteTable([note for note in self.object.notes.all() if note])
+        elif self.request.user.registration.is_admin:
+            context["notes"] = NoteTable([note for note in self.object.notes.all() if note])
         return context