Admins can validate a team or not

apps/participation/forms.py

@@ -44,6 +44,30 @@ class ParticipationForm(forms.ModelForm):
         fields = ('problem',)
 
 
+class RequestValidationForm(forms.Form):
+    _form_type = forms.CharField(
+        initial="RequestValidationForm",
+        widget=forms.HiddenInput(),
+    )
+
+    engagement = forms.BooleanField(
+        label=_("I engage myself to participate to the whole \"Correspondances\"."),
+        required=True,
+    )
+
+
+class ValidateParticipationForm(forms.Form):
+    _form_type = forms.CharField(
+        initial="ValidateParticipationForm",
+        widget=forms.HiddenInput(),
+    )
+
+    message = forms.CharField(
+        label=_("Message to address to the team:"),
+        widget=forms.Textarea(),
+    )
+
+
 class UploadVideoForm(forms.ModelForm):
     class Meta:
         model = Video

apps/participation/templates/participation/team_detail.html

@@ -78,6 +78,7 @@
                     <div class="text-center">
                         <form method="post">
                             {% csrf_token %}
+                            {{ request_validation_form|crispy }}
                             <button class="btn btn-success" name="request-validation">{% trans "Submit my team to validation" %}</button>
                         </form>
                     </div>
@@ -98,8 +99,17 @@
                 {% trans "Your validation is pending." %}
             </div>
         {% else %}
-            Team asked for validation.
-            {# TODO Add validation form: validate or invalidate, with a message #}
+            <div class="alert alert-info">
+                {% trans "The team requested to be validated. You may now control the authorizations and confirm that they can participate." %}
+            </div>
+             <form method="post">
+                {% csrf_token %}
+                {{ validation_form|crispy }}
+                <div class="input-group btn-group">
+                    <button class="btn btn-success" name="validate" type="submit">{% trans "Validate" %}</button>
+                    <button class="btn btn-danger" name="invalidate" type="submit">{% trans "Invalidate" %}</button>
+                </div>
+             </form>
         {% endif %}
     {% endif %}
 

apps/participation/views.py

@@ -6,15 +6,16 @@ from django.contrib.auth.mixins import LoginRequiredMixin
 from django.core.exceptions import PermissionDenied
 from django.db import transaction
 from django.http import HttpResponse
-from django.shortcuts import redirect
 from django.template.loader import render_to_string
 from django.urls import reverse_lazy
 from django.utils.translation import gettext_lazy as _
 from django.views.generic import CreateView, DetailView, FormView, RedirectView, UpdateView
+from django.views.generic.edit import FormMixin, ProcessFormView
 from magic import Magic
 from registration.models import AdminRegistration
 
-from .forms import JoinTeamForm, ParticipationForm, TeamForm, UploadVideoForm
+from .forms import JoinTeamForm, ParticipationForm, RequestValidationForm, TeamForm, UploadVideoForm,\
+    ValidateParticipationForm
 from .models import Participation, Team, Video
 
 
@@ -90,32 +91,22 @@ class MyTeamDetailView(LoginRequiredMixin, RedirectView):
         raise PermissionDenied(_("You don't participate, so you don't have any team."))
 
 
-class TeamDetailView(LoginRequiredMixin, DetailView):
+class TeamDetailView(LoginRequiredMixin, FormMixin, ProcessFormView, DetailView):
     model = Team
 
     def get(self, request, *args, **kwargs):
         user = request.user
+        self.object = self.get_object()
         if user.registration.is_admin or user.registration.participates and user.registration.team.pk == kwargs["pk"]:
             return super().get(request, *args, **kwargs)
         raise PermissionDenied
 
-    def post(self, request, *args, **kwargs):
-        if request.user.registration.participates:
-            if "request-validation" in request.POST:
-                request.user.registration.team.participation.valid = False
-                request.user.registration.team.participation.save()
-
-                for admin in AdminRegistration.objects.all():
-                    mail_context = dict(user=admin.user, team=request.user.registration.team)
-                    mail_plain = render_to_string("participation/mails/request_validation.txt", mail_context)
-                    mail_html = render_to_string("participation/mails/request_validation.html", mail_context)
-                    admin.user.email_user("[Corres2math] Validation d'équipe", mail_plain, html_message=mail_html)
-        return redirect(request.path)
-
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
 
-        team = self.object
+        team = self.get_object()
+        context["request_validation_form"] = RequestValidationForm(self.request.POST or None)
+        context["validation_form"] = ValidateParticipationForm(self.request.POST or None)
         context["can_validate"] = team.students.count() >= 3 and \
             all(r.email_confirmed for r in team.students.all()) and \
             all(r.photo_authorization for r in team.students.all()) and \
@@ -123,6 +114,56 @@ class TeamDetailView(LoginRequiredMixin, DetailView):
 
         return context
 
+    def get_form_class(self):
+        if not self.request.POST:
+            return RequestValidationForm
+        elif self.request.POST["_form_type"] == "RequestValidationForm":
+            return RequestValidationForm
+        elif self.request.POST["_form_type"] == "ValidateParticipationForm":
+            return ValidateParticipationForm
+        return None
+
+    def form_valid(self, form):
+        self.object = self.get_object()
+        if isinstance(form, RequestValidationForm):
+            if not self.request.user.registration.participates:
+                form.add_error(None, _("You don't participate, so you can't request the validation of the team."))
+                return self.form_invalid(form)
+            if self.object.participation.valid is not None:
+                form.add_error(None, _("The validation of the team is already done or pending."))
+                return self.form_invalid(form)
+
+            self.object.participation.valid = False
+            self.object.participation.save()
+
+            for admin in AdminRegistration.objects.all():
+                mail_context = dict(user=admin.user, team=self.object)
+                mail_plain = render_to_string("participation/mails/request_validation.txt", mail_context)
+                mail_html = render_to_string("participation/mails/request_validation.html", mail_context)
+                admin.user.email_user("[Corres2math] Validation d'équipe", mail_plain, html_message=mail_html)
+        elif isinstance(form, ValidateParticipationForm):
+            if not self.request.user.registration.is_admin:
+                form.add_error(None, _("You are not an administrator."))
+                return self.form_invalid(form)
+            elif self.object.participation.valid is not False:
+                form.add_error(None, _("This team has no pending validation."))
+                return self.form_invalid(form)
+
+            if "validate" in self.request.POST:
+                self.object.participation.valid = True
+                self.object.participation.save()
+            elif "invalidate" in self.request.POST:
+                self.object.participation.valid = None
+                self.object.participation.save()
+            else:
+                form.add_error(None, _("You must specify if you validate the registration or not."))
+                return self.form_invalid(form)
+
+        return super().form_invalid(form)
+
+    def get_success_url(self):
+        return self.request.path
+
 
 class TeamUpdateView(LoginRequiredMixin, UpdateView):
     model = Team