-
+
{% render_table table %}
diff --git a/apps/family/tests/__init__.py b/apps/family/tests/__init__.py
new file mode 100644
index 00000000..e69de29b
diff --git a/apps/family/tests/test_family.py b/apps/family/tests/test_family.py
new file mode 100644
index 00000000..f2b31784
--- /dev/null
+++ b/apps/family/tests/test_family.py
@@ -0,0 +1,318 @@
+# Copyright (C) 2018-2025 by BDE ENS Paris-Saclay
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+import os
+
+from api.tests import TestAPI
+from django.contrib.auth.models import User
+from django.core.files.uploadedfile import SimpleUploadedFile
+from django.test import TestCase
+from rest_framework.test import APITestCase
+from django.urls import reverse
+from django.utils import timezone
+
+from ..api.views import FamilyViewSet, FamilyMembershipViewSet, ChallengeViewSet, AchievementViewSet
+from ..models import Family, FamilyMembership, Challenge, Achievement
+
+
+class TestFamily(TestCase):
+ """
+ Test family
+ """
+
+ def setUp(self):
+ self.user = User.objects.create_superuser(
+ username='admintoto',
+ password='toto1234',
+ email='toto@example.com',
+ )
+ self.client.force_login(self.user)
+
+ sess = self.client.session
+ sess['permission_mask'] = 42
+ sess.save()
+
+ self.family = Family.objects.create(
+ name='Test family',
+ description='',
+ )
+
+ self.challenge = Challenge.objects.create(
+ name='Test challenge',
+ description='',
+ points=100,
+ )
+
+ self.achievement = Achievement.objects.create(
+ family=self.family,
+ challenge=self.challenge,
+ valid=False,
+ )
+
+ def test_family_list(self):
+ """
+ Test display family list
+ """
+ response = self.client.get(reverse("family:family_list"))
+ self.assertEqual(response.status_code, 200)
+
+ def test_family_create(self):
+ """
+ Test create a family
+ """
+ response = self.client.get(reverse("family:family_create"))
+ self.assertEqual(response.status_code, 200)
+
+ response = self.client.post(reverse("family:family_create"), data={
+ "name": "Family toto",
+ "description": "A test family",
+ })
+ self.assertTrue(Family.objects.filter(name="Family toto").exists())
+ self.assertRedirects(response, reverse("family:manage"), 302, 200)
+
+ def test_family_detail(self):
+ """
+ Test display the detail of a family
+ """
+ response = self.client.get(reverse("family:family_detail", args=(self.family.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ def test_family_update(self):
+ """
+ Test update a family
+ """
+ response = self.client.get(reverse("family:family_update", args=(self.family.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ response = self.client.post(reverse("family:family_update", args=(self.family.pk,)), data=dict(
+ name="Toto family updated",
+ description="A larger description for the test family"
+ ))
+ self.assertRedirects(response, self.family.get_absolute_url(), 302, 200)
+ self.assertTrue(Family.objects.filter(name="Toto family updated").exists())
+
+ def test_family_update_picture(self):
+ """
+ Test update the picture of a family
+ """
+ response = self.client.get(reverse("family:update_pic", args=(self.family.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ old_pic = self.family.display_image
+
+ with open("apps/family/static/family/img/default_picture.png", "rb") as f:
+ image = SimpleUploadedFile("image.png", f.read(), "image/png")
+ response = self.client.post(reverse("family:update_pic", args=(self.family.pk,)), dict(
+ image=image,
+ x=0,
+ y=0,
+ width=200,
+ height=200,
+ ))
+ self.assertRedirects(response, self.family.get_absolute_url(), 302, 200)
+
+ self.family.refresh_from_db()
+ self.assertTrue(os.path.exists(self.family.display_image.path))
+ os.remove(self.family.display_image.path)
+
+ self.family.display_image = old_pic
+ self.family.save()
+
+ def test_family_add_member(self):
+ """
+ Test add memberships to a family
+ """
+ response = self.client.get(reverse("family:family_add_member", args=(self.family.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ user = User.objects.create(username="totototo")
+ user.profile.registration_valid = True
+ user.profile.email_confirmed = True
+ user.profile.save()
+ user.save()
+
+ response = self.client.post(reverse("family:family_add_member", args=(self.family.pk,)), data=dict(
+ user=user.pk,
+ ))
+ self.assertRedirects(response, self.family.get_absolute_url(), 302, 200)
+
+ self.assertTrue(FamilyMembership.objects.filter(user=user, family=self.family, year=timezone.now().year).exists())
+
+ def test_challenge_list(self):
+ """
+ Test display challenge list
+ """
+ response = self.client.get(reverse('family:challenge_list'))
+ self.assertEqual(response.status_code, 200)
+
+ def test_challenge_create(self):
+ """
+ Test create a challenge
+ """
+ response = self.client.get(reverse("family:challenge_create"))
+ self.assertEqual(response.status_code, 200)
+
+ response = self.client.post(reverse("family:challenge_create"), data={
+ "name": "Challenge for toto",
+ "description": "A test challenge",
+ "points": 50,
+ })
+ self.assertTrue(Challenge.objects.filter(name="Challenge for toto").exists())
+ self.assertRedirects(response, reverse("family:manage"), 302, 200)
+
+ def test_challenge_detail(self):
+ """
+ Test display the detail of a challenge
+ """
+ response = self.client.get(reverse("family:challenge_detail", args=(self.challenge.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ def test_challenge_update(self):
+ """
+ Test update a challenge
+ """
+ response = self.client.get(reverse("family:challenge_update", args=(self.challenge.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ response = self.client.post(reverse("family:challenge_update", args=(self.challenge.pk,)), data=dict(
+ name="Challenge updated",
+ description="Another description",
+ points=10,
+ ))
+ self.assertRedirects(response, self.challenge.get_absolute_url(), 302, 200)
+ self.assertTrue(Challenge.objects.filter(name="Challenge updated").exists())
+
+ def test_render_manage_page(self):
+ """
+ Test render manage page
+ """
+ response = self.client.get(reverse("family:manage"))
+ self.assertEqual(response.status_code, 200)
+
+ def test_validate_achievement(self):
+ """
+ Test validate an achievement
+ """
+ old_family_score = self.family.score
+
+ response = self.client.get(reverse("family:achievement_validate", args=(self.achievement.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ response = self.client.post(reverse("family:achievement_validate", args=(self.achievement.pk,)))
+ self.assertRedirects(response, reverse("family:achievement_list"), 302, 200)
+
+ self.achievement.refresh_from_db()
+ self.assertIs(self.achievement.valid, True)
+
+ self.family.refresh_from_db()
+ self.assertEqual(self.family.score, old_family_score + self.achievement.challenge.points)
+
+ def test_delete_achievement(self):
+ """
+ Test delete an achievement
+ """
+ response = self.client.get(reverse("family:achievement_delete", args=(self.achievement.pk,)))
+ self.assertEqual(response.status_code, 200)
+
+ response = self.client.delete(reverse("family:achievement_delete", args=(self.achievement.pk,)))
+ self.assertRedirects(response, reverse("family:achievement_list"), 302, 200)
+ self.assertFalse(Achievement.objects.filter(pk=self.achievement.pk).exists())
+
+
+class TestBatchAchievements(APITestCase):
+ def setUp(self):
+ self.user = User.objects.create_superuser(
+ username='admintoto',
+ password='toto1234',
+ email='toto@example.com',
+ )
+ self.client.force_login(self.user)
+
+ sess = self.client.session
+ sess['permission_mask'] = 42
+ sess.save()
+
+ self.families = [
+ Family.objects.create(name=f'Famille {i}', description='') for i in range(2)
+ ]
+ self.challenges = [
+ Challenge.objects.create(name=f'Challenge {i}', description='', points=50) for i in range(3)
+ ]
+
+ self.url = reverse("family:api:batch_achievements")
+
+ def test_batch_achievement_creation(self):
+ family_ids = [f.id for f in self.families]
+ challenge_ids = [c.id for c in self.challenges]
+ response = self.client.post(
+ self.url,
+ data={
+ 'families': family_ids,
+ 'challenges': challenge_ids
+ },
+ format='json'
+ )
+
+ self.assertEqual(response.status_code, 201)
+ self.assertEqual(response.data['status'], 'ok')
+
+ expected_count = len(family_ids) * len(challenge_ids)
+ self.assertEqual(Achievement.objects.count(), expected_count)
+
+ # Check that correct couples family/challenge exist
+ for f in self.families:
+ for c in self.challenges:
+ self.assertTrue(
+ Achievement.objects.filter(family=f, challenge=c).exists()
+ )
+
+
+class TestFamilyAPI(TestAPI):
+ def setUp(self):
+ super().setUp()
+
+ self.family = Family.objects.create(
+ name='Test family',
+ description='',
+ )
+
+ self.familymembership = FamilyMembership.objects.create(
+ user=self.user,
+ family=self.family,
+ )
+
+ self.challenge = Challenge.objects.create(
+ name='Test challenge',
+ description='',
+ points=100,
+ )
+
+ self.achievement = Achievement.objects.create(
+ family=self.family,
+ challenge=self.challenge,
+ valid=False,
+ )
+
+ def test_family_api(self):
+ """
+ Load Family API page and test all filters and permissions
+ """
+ self.check_viewset(FamilyViewSet, '/api/family/family/')
+
+ def test_familymembership_api(self):
+ """
+ Load FamilyMembership API page and test all filters and permissions
+ """
+ self.check_viewset(FamilyMembershipViewSet, '/api/family/familymembership/')
+
+ def test_challenge_api(self):
+ """
+ Load Challenge API page and test all filters and permissions
+ """
+ self.check_viewset(ChallengeViewSet, '/api/family/challenge/')
+
+ def test_achievement_api(self):
+ """
+ Load Achievement API page and test all filters and permissions
+ """
+ self.check_viewset(AchievementViewSet, '/api/family/achievement/')
diff --git a/apps/family/urls.py b/apps/family/urls.py
index 7d9e9c5b..edb0d18a 100644
--- a/apps/family/urls.py
+++ b/apps/family/urls.py
@@ -8,18 +8,18 @@ from . import views
app_name = 'family'
urlpatterns = [
path('list/', views.FamilyListView.as_view(), name="family_list"),
- path('add-family/', views.FamilyCreateView.as_view(), name="add_family"),
+ path('create/', views.FamilyCreateView.as_view(), name="family_create"),
path('
/detail/', views.FamilyDetailView.as_view(), name="family_detail"),
path('/update/', views.FamilyUpdateView.as_view(), name="family_update"),
path('/update_pic/', views.FamilyPictureUpdateView.as_view(), name="update_pic"),
path('/add_member/', views.FamilyAddMemberView.as_view(), name="family_add_member"),
path('challenge/list/', views.ChallengeListView.as_view(), name="challenge_list"),
- path('add-challenge/', views.ChallengeCreateView.as_view(), name="add_challenge"),
+ path('challenge/create/', views.ChallengeCreateView.as_view(), name="challenge_create"),
path('challenge//detail/', views.ChallengeDetailView.as_view(), name="challenge_detail"),
path('challenge//update/', views.ChallengeUpdateView.as_view(), name="challenge_update"),
path('manage/', views.FamilyManageView.as_view(), name="manage"),
- path('achievement/list/', views.AchievementsView.as_view(), name="achievement_list"),
+ path('achievement/list/', views.AchievementListView.as_view(), name="achievement_list"),
path('achievement//validate/', views.AchievementValidateView.as_view(), name="achievement_validate"),
path('achievement//delete/', views.AchievementDeleteView.as_view(), name="achievement_delete"),
- path('api/family/', include('family.api.urls')),
+ path('api/family/', include(('family.api.urls', 'family_api'), namespace='api')),
]
diff --git a/apps/family/views.py b/apps/family/views.py
index a6e886a8..aee6f276 100644
--- a/apps/family/views.py
+++ b/apps/family/views.py
@@ -8,14 +8,14 @@ from django.shortcuts import redirect
from django.contrib.auth.mixins import LoginRequiredMixin
from django.db import transaction
from django.views.generic import DetailView, UpdateView, ListView
-from django.views.generic.edit import DeleteView
+from django.views.generic.edit import DeleteView, FormMixin
from django.views.generic.base import TemplateView
from django.utils.translation import gettext_lazy as _
from django_tables2 import SingleTableView, MultiTableMixin
from permission.backends import PermissionBackend
from permission.views import ProtectQuerysetMixin, ProtectedCreateView
from django.urls import reverse_lazy
-from member.views import PictureUpdateView
+from member.forms import ImageForm
from .models import Family, Challenge, FamilyMembership, User, Achievement
from .tables import FamilyTable, ChallengeTable, FamilyMembershipTable, AchievementTable, FamilyAchievementTable
@@ -112,17 +112,28 @@ class FamilyUpdateView(ProtectQuerysetMixin, LoginRequiredMixin, UpdateView):
return reverse_lazy('family:family_detail', kwargs={'pk': self.object.pk})
-class FamilyPictureUpdateView(PictureUpdateView):
+class FamilyPictureUpdateView(ProtectQuerysetMixin, LoginRequiredMixin, FormMixin, DetailView):
"""
Update profile picture of the family
"""
model = Family
extra_context = {"title": _("Update family picture")}
template_name = 'family/picture_update.html'
+ form_class = ImageForm
+
+ def get_context_data(self, **kwargs):
+ context = super().get_context_data(**kwargs)
+ context['form'] = self.form_class(self.request.POST, self.request.FILES)
+ return context
def get_success_url(self):
"""Redirect to family page after upload"""
- return reverse_lazy('family:family_detail', kwargs={'pk': self.object.id})
+ return reverse_lazy('family:family_detail', kwargs={'pk': self.object.pk})
+
+ def post(self, request, *args, **kwargs):
+ form = self.get_form()
+ self.object = self.get_object()
+ return self.form_valid(form) if form.is_valid() else self.form_invalid(form)
@transaction.atomic
def form_valid(self, form):
@@ -141,6 +152,11 @@ class FamilyPictureUpdateView(PictureUpdateView):
else:
image.name = "{}_pic.png".format(self.object.pk)
+ # Save
+ self.object.display_image = image
+ self.object.save()
+ return super().form_valid(form)
+
class FamilyAddMemberView(ProtectQuerysetMixin, ProtectedCreateView):
"""
@@ -282,8 +298,8 @@ class FamilyManageView(ProtectQuerysetMixin, LoginRequiredMixin, SingleTableView
PermissionBackend.filter_queryset(self.request, Challenge, "view")
).order_by('name')
- context["can_add_family"] = PermissionBackend.check_perm(self.request, "family.add_family")
- context["can_add_challenge"] = PermissionBackend.check_perm(self.request, "family.add_challenge")
+ context["can_add_family"] = PermissionBackend.check_perm(self.request, "family.family_create")
+ context["can_add_challenge"] = PermissionBackend.check_perm(self.request, "family.challenge_create")
return context
@@ -294,7 +310,7 @@ class FamilyManageView(ProtectQuerysetMixin, LoginRequiredMixin, SingleTableView
return table
-class AchievementsView(ProtectQuerysetMixin, LoginRequiredMixin, MultiTableMixin, ListView):
+class AchievementListView(ProtectQuerysetMixin, LoginRequiredMixin, MultiTableMixin, ListView):
"""
List all achievements
"""
@@ -333,12 +349,11 @@ class AchievementValidateView(ProtectQuerysetMixin, LoginRequiredMixin, Template
template_name = 'family/achievement_confirm_validate.html'
def post(self, request, pk):
- # On récupère l'objet à valider
achievement = Achievement.objects.get(pk=pk)
- # On modifie le champ valid
+
achievement.valid = True
achievement.save()
- # On redirige vers la page de détail ou la liste
+
return redirect(reverse_lazy('family:achievement_list'))