Fix CI

apps/member/views.py

@@ -6,22 +6,18 @@ import io
 from PIL import Image
 from dal import autocomplete
 from django.conf import settings
-from django.contrib import messages
 from django.contrib.auth.mixins import LoginRequiredMixin
 from django.contrib.auth.models import User
 from django.contrib.auth.views import LoginView
-from django.core.exceptions import ValidationError
 from django.db.models import Q
-from django.http import HttpResponseRedirect
 from django.shortcuts import redirect
 from django.urls import reverse_lazy
 from django.utils.translation import gettext_lazy as _
-from django.views.generic import CreateView, DetailView, UpdateView, TemplateView, DeleteView
+from django.views.generic import CreateView, DetailView, UpdateView, TemplateView
 from django.views.generic.edit import FormMixin
 from django_tables2.views import SingleTableView
 from rest_framework.authtoken.models import Token
 from note.forms import ImageForm
-#from note.forms import AliasForm, ImageForm
 from note.models import Alias, NoteUser
 from note.models.transactions import Transaction
 from note.tables import HistoryTable, AliasTable
@@ -168,12 +164,12 @@ class UserListView(LoginRequiredMixin, SingleTableView):
         context["filter"] = self.filter
         return context
 
-    
+
 class ProfileAliasView(LoginRequiredMixin, DetailView):
     model = User
     template_name = 'member/profile_alias.html'
     context_object_name = 'user_object'
-    
+
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         note = context['object'].note
@@ -326,11 +322,12 @@ class ClubDetailView(LoginRequiredMixin, DetailView):
         context['member_list'] = club_member
         return context
 
+
 class ClubAliasView(LoginRequiredMixin, DetailView):
     model = Club
     template_name = 'member/club_alias.html'
     context_object_name = 'club'
-    
+
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         note = context['object'].note
@@ -364,6 +361,7 @@ class ClubAddMemberView(LoginRequiredMixin, CreateView):
         return super().get_queryset().filter(PermissionBackend.filter_queryset(self.request.user, Membership, "view")
                                              | PermissionBackend.filter_queryset(self.request.user, Membership,
                                                                                  "change"))
+
     def get_context_data(self, **kwargs):
         club = Club.objects.get(pk=self.kwargs["pk"])
         context = super().get_context_data(**kwargs)

apps/note/api/views.py

@@ -8,7 +8,6 @@ from rest_framework.filters import OrderingFilter, SearchFilter
 from rest_framework import viewsets
 from rest_framework.response import Response
 from rest_framework import status
-
 from api.viewsets import ReadProtectedModelViewSet, ReadOnlyProtectedModelViewSet
 
 from .serializers import NotePolymorphicSerializer, AliasSerializer, TemplateCategorySerializer, \
@@ -60,19 +59,19 @@ class AliasViewSet(ReadProtectedModelViewSet):
     def get_serializer_class(self):
         serializer_class = self.serializer_class
         if self.request.method in ['PUT', 'PATCH']:
-            #alias owner cannot be change once establish
+            # alias owner cannot be change once establish
             setattr(serializer_class.Meta, 'read_only_fields', ('note',))
         return serializer_class
-    
+
     def destroy(self, request, *args, **kwargs):
         instance = self.get_object()
         try:
             self.perform_destroy(instance)
         except ValidationError as e:
             print(e)
-            return Response({e.code:e.message},status.HTTP_400_BAD_REQUEST)
+            return Response({e.code: e.message}, status.HTTP_400_BAD_REQUEST)
         return Response(status=status.HTTP_204_NO_CONTENT)
-    
+
     def get_queryset(self):
         """
         Parse query and apply filters.

apps/note/forms.py

@@ -5,7 +5,6 @@ from dal import autocomplete
 from django import forms
 from django.utils.translation import gettext_lazy as _
 
-from .models import Alias
 from .models import TransactionTemplate
 
 

apps/note/models/notes.py

@@ -242,10 +242,10 @@ class Alias(models.Model):
             pass
         self.normalized_name = normalized_name
 
-    def save(self,*args,**kwargs):
+    def save(self, *args, **kwargs):
         self.normalized_name = self.normalize(self.name)
-        super().save(*args,**kwargs)
+        super().save(*args, **kwargs)
-        
+
     def delete(self, using=None, keep_parents=False):
         if self.name == str(self.note):
             raise ValidationError(_("You can't delete your main alias."),

apps/note/models/transactions.py

@@ -2,7 +2,6 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from django.db import models
-from django.db.models import F
 from django.urls import reverse
 from django.utils import timezone
 from django.utils.translation import gettext_lazy as _

apps/note/tables.py

@@ -106,9 +106,8 @@ DELETE_TEMPLATE = """
 class AliasTable(tables.Table):
     class Meta:
         attrs = {
-            'class':
+            'class': 'table table condensed table-striped table-hover',
-                'table table condensed table-striped table-hover',
+            'id': "alias_table"
-            'id':"alias_table"
         }
         model = Alias
         fields = ('name',)
@@ -118,9 +117,8 @@ class AliasTable(tables.Table):
     name = tables.Column(attrs={'td': {'class': 'text-center'}})
 
     delete_col = tables.TemplateColumn(template_code=DELETE_TEMPLATE,
-                                   extra_context={"delete_trans": _('delete')},
+                                       extra_context={"delete_trans": _('delete')},
-                                   attrs={'td': {'class': 'col-sm-1'}})
+                                       attrs={'td': {'class': 'col-sm-1'}})
-
 
 
 class ButtonTable(tables.Table):
@@ -145,8 +143,8 @@ class ButtonTable(tables.Table):
                              accessor='pk')
 
     delete_col = tables.TemplateColumn(template_code=DELETE_TEMPLATE,
-                                   extra_context={"delete_trans": _('delete')},
+                                       extra_context={"delete_trans": _('delete')},
-                                   attrs={'td': {'class': 'col-sm-1'}})
+                                       attrs={'td': {'class': 'col-sm-1'}})
 
     def render_amount(self, value):
         return pretty_money(value)