From 5ebdb015ad52cd205e6eec8f957cbe114c061bb4 Mon Sep 17 00:00:00 2001 From: Yohann D'ANELLO Date: Sun, 6 Sep 2020 13:30:38 +0200 Subject: [PATCH] Decompose some membership functions, now we have a good linting :) --- apps/member/models.py | 83 +++++++++++++++++++---------------- apps/member/views.py | 100 ++++++++++++++++++++++++++---------------- 2 files changed, 107 insertions(+), 76 deletions(-) diff --git a/apps/member/models.py b/apps/member/models.py index d1218e94..bce525af 100644 --- a/apps/member/models.py +++ b/apps/member/models.py @@ -341,6 +341,9 @@ class Membership(models.Model): return self.date_start.toordinal() <= datetime.datetime.now().toordinal() def renew(self): + """ + If the current membership comes to expiration, create a new membership that starts immediately after this one. + """ if not Membership.objects.filter( user=self.user, club=self.club, @@ -362,6 +365,48 @@ class Membership(models.Model): new_membership.roles.set(self.roles.all()) new_membership.save() + def renew_parent(self): + """ + Ensure that the parent membership is renewed, and renew/create it if needed. + """ + parent_membership = Membership.objects.filter( + user=self.user, + club=self.club.parent_club, + ).order_by("-date_start") + if parent_membership.exists(): + # Renew the previous membership of the parent club + parent_membership = parent_membership.first() + parent_membership._force_renew_parent = True + if hasattr(self, '_soge'): + parent_membership._soge = True + if hasattr(self, '_force_save'): + parent_membership._force_save = True + parent_membership.renew() + else: + # Create a new membership in the parent club + parent_membership = Membership( + user=self.user, + club=self.club.parent_club, + date_start=self.date_start, + ) + parent_membership._force_renew_parent = True + if hasattr(self, '_soge'): + parent_membership._soge = True + if hasattr(self, '_force_save'): + parent_membership._force_save = True + parent_membership.save() + parent_membership.refresh_from_db() + + if self.club.parent_club.name == "BDE": + parent_membership.roles.set( + Role.objects.filter(Q(name="Adhérent BDE") | Q(name="Membre de club")).all()) + elif self.club.parent_club.name == "Kfet": + parent_membership.roles.set( + Role.objects.filter(Q(name="Adhérent Kfet") | Q(name="Membre de club")).all()) + else: + parent_membership.roles.set(Role.objects.filter(name="Membre de club").all()) + parent_membership.save() + def save(self, *args, **kwargs): """ Calculate fee and end date before saving the membership and creating the transaction if needed. @@ -391,43 +436,7 @@ class Membership(models.Model): date_start__gte=self.club.parent_club.membership_start, ).exists(): if hasattr(self, '_force_renew_parent') and self._force_renew_parent: - parent_membership = Membership.objects.filter( - user=self.user, - club=self.club.parent_club, - ).order_by("-date_start") - if parent_membership.exists(): - # Renew the previous membership of the parent club - parent_membership = parent_membership.first() - parent_membership._force_renew_parent = True - if hasattr(self, '_soge'): - parent_membership._soge = True - if hasattr(self, '_force_save'): - parent_membership._force_save = True - parent_membership.renew() - else: - # Create a new membership in the parent club - parent_membership = Membership( - user=self.user, - club=self.club.parent_club, - date_start=self.date_start, - ) - parent_membership._force_renew_parent = True - if hasattr(self, '_soge'): - parent_membership._soge = True - if hasattr(self, '_force_save'): - parent_membership._force_save = True - parent_membership.save() - parent_membership.refresh_from_db() - - if self.club.parent_club.name == "BDE": - parent_membership.roles.set( - Role.objects.filter(Q(name="Adhérent BDE") | Q(name="Membre de club")).all()) - elif self.club.parent_club.name == "Kfet": - parent_membership.roles.set( - Role.objects.filter(Q(name="Adhérent Kfet") | Q(name="Membre de club")).all()) - else: - parent_membership.roles.set(Role.objects.filter(name="Membre de club").all()) - parent_membership.save() + self.renew_parent() else: raise ValidationError(_('User is not a member of the parent club') + ' ' + self.club.parent_club.name) diff --git a/apps/member/views.py b/apps/member/views.py index 2a0394ff..746f5c94 100644 --- a/apps/member/views.py +++ b/apps/member/views.py @@ -584,6 +584,64 @@ class ClubAddMemberView(ProtectQuerysetMixin, ProtectedCreateView): return context + def perform_verifications(self, form, user, club, fee): + """ + Make some additional verifications to check that the membership can be created. + :return: True if the form is clean, False if there is an error. + """ + error = False + + # Retrieve form data + credit_type = form.cleaned_data["credit_type"] + credit_amount = form.cleaned_data["credit_amount"] + last_name = form.cleaned_data["last_name"] + first_name = form.cleaned_data["first_name"] + bank = form.cleaned_data["bank"] + soge = form.cleaned_data["soge"] and not user.profile.soge and (club.name == "BDE" or club.name == "Kfet") + + if not soge and user.note.balance + credit_amount < fee and not Membership.objects.filter( + club__name="Kfet", + user=user, + date_start__lte=date.today(), + date_end__gte=date.today(), + ).exists(): + # Users without a valid Kfet membership can't have a negative balance. + # TODO Send a notification to the user (with a mail?) to tell her/him to credit her/his note + form.add_error('user', + _("This user don't have enough money to join this club, and can't have a negative balance.")) + error = True + + if Membership.objects.filter( + user=form.instance.user, + club=club, + date_start__lte=form.instance.date_start, + date_end__gte=form.instance.date_start, + ).exists(): + form.add_error('user', _('User is already a member of the club')) + error = True + + if club.membership_start and form.instance.date_start < club.membership_start: + form.add_error('user', _("The membership must start after {:%m-%d-%Y}.") + .format(form.instance.club.membership_start)) + error = True + + if club.membership_end and form.instance.date_start > club.membership_end: + form.add_error('user', _("The membership must begin before {:%m-%d-%Y}.") + .format(form.instance.club.membership_end)) + error = True + + if credit_amount: + if not last_name or not first_name or (not bank and credit_type.special_type == "Chèque"): + if not last_name: + form.add_error('last_name', _("This field is required.")) + if not first_name: + form.add_error('first_name', _("This field is required.")) + if not bank and credit_type.special_type == "Chèque": + form.add_error('bank', _("This field is required.")) + return self.form_invalid(form) + + return not error + def form_valid(self, form): """ Create membership, check that all is good, make transactions @@ -630,36 +688,9 @@ class ClubAddMemberView(ProtectQuerysetMixin, ProtectedCreateView): fee += c.membership_fee_paid if user.profile.paid else c.membership_fee_unpaid c = c.parent_club - if not soge and user.note.balance + credit_amount < fee and not Membership.objects.filter( - club__name="Kfet", - user=user, - date_start__lte=date.today(), - date_end__gte=date.today(), - ).exists(): - # Users without a valid Kfet membership can't have a negative balance. - # TODO Send a notification to the user (with a mail?) to tell her/him to credit her/his note - form.add_error('user', - _("This user don't have enough money to join this club, and can't have a negative balance.")) - return super().form_invalid(form) - - if Membership.objects.filter( - user=form.instance.user, - club=club, - date_start__lte=form.instance.date_start, - date_end__gte=form.instance.date_start, - ).exists(): - form.add_error('user', _('User is already a member of the club')) - return super().form_invalid(form) - - if club.membership_start and form.instance.date_start < club.membership_start: - form.add_error('user', _("The membership must start after {:%m-%d-%Y}.") - .format(form.instance.club.membership_start)) - return super().form_invalid(form) - - if club.membership_end and form.instance.date_start > club.membership_end: - form.add_error('user', _("The membership must begin before {:%m-%d-%Y}.") - .format(form.instance.club.membership_end)) - return super().form_invalid(form) + # Make some verifications about the form, and if there is an error, then assume that the form is invalid + if not self.perform_verifications(form, user, club, fee): + return self.form_invalid(form) # Now, all is fine, the membership can be created. @@ -671,15 +702,6 @@ class ClubAddMemberView(ProtectQuerysetMixin, ProtectedCreateView): # Credit note before the membership is created. if credit_amount > 0: - if not last_name or not first_name or (not bank and credit_type.special_type == "Chèque"): - if not last_name: - form.add_error('last_name', _("This field is required.")) - if not first_name: - form.add_error('first_name', _("This field is required.")) - if not bank and credit_type.special_type == "Chèque": - form.add_error('bank', _("This field is required.")) - return self.form_invalid(form) - transaction = SpecialTransaction( source=credit_type, destination=user.note,