ynerant
/
nk20
mirror of https://gitlab.crans.org/bde/nk20
1
0
Fork 0
Code Issues Releases Wiki Activity

Use python Warnings instead of printing messages during tests 

Signed-off-by: Yohann D'ANELLO <yohann.danello@gmail.com>
This commit is contained in:
Yohann D'ANELLO 2020-12-23 15:11:33 +01:00
parent 3a20555663
commit 5cb4183e9f
Signed by: ynerant
GPG Key ID: 3A75C55819C8CF85
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/api/tests.py
View File

@ -4,6 +4,7 @@
import json import json
from datetime import datetime from datetime import datetime
from urllib.parse import quote_plus from urllib.parse import quote_plus
from warnings import warn
from django.contrib.auth.models import User from django.contrib.auth.models import User
from django.test import TestCase from django.test import TestCase
@ -46,7 +47,7 @@ class TestAPI(TestCase):
model = viewset.serializer_class.Meta.model model = viewset.serializer_class.Meta.model
if not model.objects.exists(): # pragma: no cover if not model.objects.exists(): # pragma: no cover
print(f"Warning: unable to test API filters for the model {model._meta.verbose_name} " warn(f"Warning: unable to test API filters for the model {model._meta.verbose_name} "
"since there is no instance of it.") "since there is no instance of it.")
return return
@ -61,7 +62,7 @@ class TestAPI(TestCase):
value = self.get_value(obj, field) value = self.get_value(obj, field)
if value is None: # pragma: no cover if value is None: # pragma: no cover
print(f"Warning: the filter {field} for the model {model._meta.verbose_name} " warn(f"Warning: the filter {field} for the model {model._meta.verbose_name} "
"has not been tested.") "has not been tested.")
continue continue
resp = self.client.get(url + f"?format=json&{field}={quote_plus(str(value))}") resp = self.client.get(url + f"?format=json&{field}={quote_plus(str(value))}")
@ -90,7 +91,7 @@ class TestAPI(TestCase):
field = field[1:] field = field[1:]
value = self.get_value(obj, field) value = self.get_value(obj, field)
if value is None: # pragma: no cover if value is None: # pragma: no cover
print(f"Warning: the filter {field} for the model {model._meta.verbose_name} " warn(f"Warning: the filter {field} for the model {model._meta.verbose_name} "
"has not been tested.") "has not been tested.")
continue continue
resp = self.client.get(url + f"?format=json&search={quote_plus(str(value))}") resp = self.client.get(url + f"?format=json&search={quote_plus(str(value))}")