From 58d5b5a9ffbd2d4a9e647f45462736247c462ba2 Mon Sep 17 00:00:00 2001
From: Alexandre Iooss <erdnaxe@crans.org>
Date: Tue, 16 Jul 2019 09:05:30 +0200
Subject: [PATCH] Clean up note app

---
 note/__init__.py       |  5 ++++
 note/admin.py          |  3 ++-
 note/apps.py           |  6 +++++
 note/models.py         | 60 ++++++++++++++++++++++++------------------
 note/tests.py          |  3 ---
 note/tests/__init__.py |  0
 note/views.py          |  3 ---
 7 files changed, 47 insertions(+), 33 deletions(-)
 delete mode 100644 note/tests.py
 create mode 100644 note/tests/__init__.py
 delete mode 100644 note/views.py

diff --git a/note/__init__.py b/note/__init__.py
index e69de29b..4773b310 100644
--- a/note/__init__.py
+++ b/note/__init__.py
@@ -0,0 +1,5 @@
+# -*- mode: python; coding: utf-8 -*-
+# Copyright (C) 2018-2019 by BDE ENS Paris-Saclay
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+default_app_config = 'note.apps.NoteConfig'
diff --git a/note/admin.py b/note/admin.py
index d7ff9c07..122c11e3 100644
--- a/note/admin.py
+++ b/note/admin.py
@@ -1,7 +1,8 @@
 from django.contrib import admin
 
-from .models import NoteClub,NoteSpec,NoteUser
+from .models import NoteClub, NoteSpec, NoteUser
 from .models import Alias
+
 # Register your models here.
 admin.site.register(NoteClub)
 admin.site.register(NoteSpec)
diff --git a/note/apps.py b/note/apps.py
index eab40c5e..439140b3 100644
--- a/note/apps.py
+++ b/note/apps.py
@@ -1,5 +1,11 @@
+# -*- mode: python; coding: utf-8 -*-
+# Copyright (C) 2018-2019 by BDE ENS Paris-Saclay
+# SPDX-License-Identifier: GPL-3.0-or-later
+
 from django.apps import AppConfig
+from django.utils.translation import gettext_lazy as _
 
 
 class NoteConfig(AppConfig):
     name = 'note'
+    verbose_name = _('note')
diff --git a/note/models.py b/note/models.py
index d5b2ebdd..d0f088c0 100644
--- a/note/models.py
+++ b/note/models.py
@@ -17,46 +17,52 @@ class Alias(models.Model):
     """
     alias = models.TextField(
         "alias",
-        unique = True,
-        blank = False,
-        null = False,
+        unique=True,
+        blank=False,
+        null=False,
     )
-    limit = models.Q(app_label="note", model="NoteUser") | models.Q(app_label="note",model="NoteClub")
 
+    # Owner can be linked to an user note or a club note
+    limit = models.Q(app_label="note", model="NoteUser") | models.Q(app_label="note", model="NoteClub")
     owner_id = models.PositiveIntegerField()
-    owner_type = models.ForeignKey(ContentType,
-                                   on_delete=models.CASCADE,
-                                   limit_choices_to=limit)
-    owner = GenericForeignKey('owner_type','owner_id')
+    owner_type = models.ForeignKey(
+        ContentType,
+        on_delete=models.CASCADE,
+        limit_choices_to=limit
+    )
+    owner = GenericForeignKey('owner_type', 'owner_id')
+
 
 class Note(models.Model):
     """
     An abstract model, use to add transactions capabilities to a user
     """
-
-    solde = models.IntegerField(
-        verbose_name=_('solde du compte'),
-        help_text=_("en centime, l' argent crédité pour cette instance")
+    balance = models.DecimalField(
+        verbose_name=_('account balance'),
+        help_text=_("money credited for this instance"),
+        decimal_places=2,  # Limit to centimes
     )
-    active = models.BooleanField(
-        default = True,
-        verbose_name=_('etat du compte')
+    is_active = models.BooleanField(
+        default=True,
+        verbose_name=_('is active')
     )
 
     class Meta:
         abstract = True
 
+
 class NoteUser(Note):
     """
-    A Note associated to a User
+    A Note associated to an User
     """
     user = models.OneToOneField(
         settings.AUTH_USER_MODEL,
         on_delete=models.CASCADE,
     )
+
     class Meta:
-        verbose_name = _("One's Note")
-        verbose_name_plural = _("Users Note")
+        verbose_name = _("one's note")
+        verbose_name_plural = _("users note")
 
     def __str__(self):
         return self.user.get_username()
@@ -72,16 +78,18 @@ class NoteSpec(Note):
      - Refund
     """
     account_type = models.CharField(
-        max_length = 2,
-        choices = (("CH","chèques"),
-                   ("CB","Carte Bancaire"),
-                   ("VB","Virement Bancaire"),
-                   ("CA","Cash"),
-                   ("RB","Remboursement")
+        max_length=2,
+        choices=(
+            ("CH", "chèques"),
+            ("CB", "Carte Bancaire"),
+            ("VB", "Virement Bancaire"),
+            ("CA", "Cash"),
+            ("RB", "Remboursement")
         ),
-        unique = True
+        unique=True,
     )
 
+
 class NoteClub(Note):
-    #to be added
+    # to be added
     pass
diff --git a/note/tests.py b/note/tests.py
deleted file mode 100644
index 7ce503c2..00000000
--- a/note/tests.py
+++ /dev/null
@@ -1,3 +0,0 @@
-from django.test import TestCase
-
-# Create your tests here.
diff --git a/note/tests/__init__.py b/note/tests/__init__.py
new file mode 100644
index 00000000..e69de29b
diff --git a/note/views.py b/note/views.py
deleted file mode 100644
index 91ea44a2..00000000
--- a/note/views.py
+++ /dev/null
@@ -1,3 +0,0 @@
-from django.shortcuts import render
-
-# Create your views here.