💚 Linting should not fail the CI

This commit is contained in:
Yohann D'ANELLO 2020-09-27 21:31:35 +02:00
parent 8b8b99c6ae
commit ac1e9fdc88
3 changed files with 4 additions and 3 deletions

View File

@ -17,4 +17,5 @@ linters:
stage: quality-assurance stage: quality-assurance
script: script:
- go get -u golang.org/x/lint/golint - go get -u golang.org/x/lint/golint
- golint -min_confidence 0 -set_exit_status ./... - golint -min_confidence 0.3 -set_exit_status ./...
allow_failure: true

View File

@ -37,7 +37,7 @@ func New(cfg *Options) (Backend, error) {
backend, err = ldap.New(&cfg.LDAP) backend, err = ldap.New(&cfg.LDAP)
default: default:
// Package is misconfigured // Package is misconfigured
backend, err = nil, errors.New("Authentification backend not found") backend, err = nil, errors.New("authentification backend not found")
} }
if err != nil { if err != nil {

View File

@ -25,7 +25,7 @@ type Basic struct {
func (a Basic) Login(username string, password string) (bool, error) { func (a Basic) Login(username string, password string) (bool, error) {
hash, ok := a.Cfg.Credentials[username] hash, ok := a.Cfg.Credentials[username]
if !ok { if !ok {
return false, errors.New("User not found in credentials") return false, errors.New("user not found in credentials")
} }
err := bcrypt.CompareHashAndPassword([]byte(hash), []byte(password)) err := bcrypt.CompareHashAndPassword([]byte(hash), []byte(password))