From f4ece7f1f2443090e6b2894f94cb82981507685a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=92=9F=E9=9B=AA=E6=9D=BE?= Date: Fri, 25 Jan 2019 15:28:07 +0800 Subject: [PATCH 1/6] set ldap3 client_strategy from sync to sync-restartable; in order to avoid error 32 broken pipe caused by time out --- cas_server/auth.py | 1 + 1 file changed, 1 insertion(+) diff --git a/cas_server/auth.py b/cas_server/auth.py index 4a5b141..0e07d74 100644 --- a/cas_server/auth.py +++ b/cas_server/auth.py @@ -277,6 +277,7 @@ class LdapAuthUser(DBAuthUser): # pragma: no cover settings.CAS_LDAP_SERVER, settings.CAS_LDAP_USER, settings.CAS_LDAP_PASSWORD, + client_strategy="RESTARTABLE", auto_bind=True ) cls._conn = conn From 1bdfd2d0dbc0f899f63778755317a3b060a3c562 Mon Sep 17 00:00:00 2001 From: Valentin Samir Date: Sat, 2 Mar 2019 11:22:43 +0100 Subject: [PATCH 2/6] Edit changelog for pull request bf44b4f30513232c72815caa9bc6511f585b38bb --- CHANGELOG.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index d0fd75e..4f849a3 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -6,12 +6,20 @@ All notable changes to this project will be documented in this file. .. contents:: Table of Contents :depth: 2 +Unreleased +========== + +Fixes +----- + +* Set ldap3 client_strategy from sync to sync-restartable v1.0.0 - 2019-01-12 =================== Added ----- + * Support for python 3.6 and Django 1.11 * Support for Django 2.0 * Keep query string then redirecting from / to /login From 9ee95f0bec214bafd774077bbdee7066a849fb90 Mon Sep 17 00:00:00 2001 From: Valentin Samir Date: Sat, 2 Mar 2019 11:23:16 +0100 Subject: [PATCH 3/6] Fix checkbox position on the login page --- CHANGELOG.rst | 1 + cas_server/forms.py | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 4f849a3..e0beb0a 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -12,6 +12,7 @@ Unreleased Fixes ----- +* Fix checkbox position on the login page * Set ldap3 client_strategy from sync to sync-restartable v1.0.0 - 2019-01-12 diff --git a/cas_server/forms.py b/cas_server/forms.py index 3c42bab..107423c 100644 --- a/cas_server/forms.py +++ b/cas_server/forms.py @@ -31,7 +31,10 @@ class BootsrapForm(forms.Form): # Only tweak the field if it will be displayed if not isinstance(field.widget, widgets.HiddenInput): attrs = {} - if isinstance(field.widget, (widgets.Input, widgets.Select, widgets.Textarea)): + if ( + isinstance(field.widget, (widgets.Input, widgets.Select, widgets.Textarea)) and + not isinstance(field.widget, (widgets.CheckboxInput,)) + ): attrs['class'] = "form-control" if isinstance(field.widget, (widgets.Input, widgets.Textarea)) and field.label: attrs["placeholder"] = field.label From 4025fcbf11405b0863c0c64b49d2bff4556a3089 Mon Sep 17 00:00:00 2001 From: Valentin Samir Date: Sat, 2 Mar 2019 11:23:30 +0100 Subject: [PATCH 4/6] Add support for Django 2.1 --- .travis.yml | 4 ++++ CHANGELOG.rst | 5 +++++ requirements.txt | 2 +- setup.py | 3 ++- tox.ini | 14 ++++++++++++++ 5 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index a81c37f..5b8a997 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,6 +15,10 @@ matrix: env: TOX_ENV=py35-django20 - python: "3.6" env: TOX_ENV=py36-django20 + - python: "3.5" + env: TOX_ENV=py35-django21 + - python: "3.6" + env: TOX_ENV=py36-django21 - python: "2.7" env: TOX_ENV=coverage cache: diff --git a/CHANGELOG.rst b/CHANGELOG.rst index e0beb0a..3004bd7 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file. Unreleased ========== +Added +----- + +* Support for Django 2.1 + Fixes ----- diff --git a/requirements.txt b/requirements.txt index 6e4edbe..95b36d9 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,4 +1,4 @@ -Django >= 1.11,<2.1 +Django >= 1.11,<2.2 setuptools>=5.5 requests>=2.4 requests_futures>=0.9.5 diff --git a/setup.py b/setup.py index 2e1d0ad..4c4af3b 100644 --- a/setup.py +++ b/setup.py @@ -33,6 +33,7 @@ if __name__ == '__main__': 'Framework :: Django', 'Framework :: Django :: 1.11', 'Framework :: Django :: 2.0', + 'Framework :: Django :: 2.1', 'Intended Audience :: Developers', 'Intended Audience :: System Administrators', 'License :: OSI Approved :: GNU General Public License v3 (GPLv3)', @@ -57,7 +58,7 @@ if __name__ == '__main__': }, keywords=['django', 'cas', 'cas3', 'server', 'sso', 'single sign-on', 'authentication', 'auth'], install_requires=[ - 'Django >= 1.11,<2.1', 'requests >= 2.4', 'requests_futures >= 0.9.5', + 'Django >= 1.11,<2.2', 'requests >= 2.4', 'requests_futures >= 0.9.5', 'lxml >= 3.4', 'six >= 1' ], url="https://github.com/nitmir/django-cas-server", diff --git a/tox.ini b/tox.ini index 1a1c2cf..ab93ef5 100644 --- a/tox.ini +++ b/tox.ini @@ -7,6 +7,8 @@ envlist= py36-django111, py35-django20, py36-django20, + py35-django21, + py36-django21, [flake8] max-line-length=100 @@ -104,6 +106,18 @@ deps = Django>=2.0,<2.1 {[base]deps} +[testenv:py35-django21] +basepython=python3.5 +deps = + Django>=2.1,<2.2 + {[base]deps} + +[testenv:py36-django21] +basepython=python3.6 +deps = + Django>=2.1,<2.2 + {[base]deps} + [testenv:flake8] From 378f70fac9de43e3c233b45bf0f5ab583faca9c1 Mon Sep 17 00:00:00 2001 From: Valentin Samir Date: Sat, 2 Mar 2019 11:31:18 +0100 Subject: [PATCH 5/6] Fix deprecation warning for {% load staticfiles %} and django.contrib.staticfiles --- CHANGELOG.rst | 3 ++- cas_server/default_settings.py | 2 +- cas_server/templates/cas_server/base.html | 2 +- cas_server/templates/cas_server/logout.html | 2 +- cas_server/templates/cas_server/warn.html | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 3004bd7..58312d6 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -17,8 +17,9 @@ Added Fixes ----- -* Fix checkbox position on the login page +* Checkbox position on the login page * Set ldap3 client_strategy from sync to sync-restartable +* Deprecation warning for {% load staticfiles %} and django.contrib.staticfiles v1.0.0 - 2019-01-12 =================== diff --git a/cas_server/default_settings.py b/cas_server/default_settings.py index 64d0140..14b2352 100644 --- a/cas_server/default_settings.py +++ b/cas_server/default_settings.py @@ -11,7 +11,7 @@ # (c) 2015-2016 Valentin Samir """Default values for the app's settings""" from django.conf import settings -from django.contrib.staticfiles.templatetags.staticfiles import static +from django.templatetags.static import static from django.utils.translation import ugettext_lazy as _ from importlib import import_module diff --git a/cas_server/templates/cas_server/base.html b/cas_server/templates/cas_server/base.html index 927df1f..9980d38 100644 --- a/cas_server/templates/cas_server/base.html +++ b/cas_server/templates/cas_server/base.html @@ -1,4 +1,4 @@ -{% load i18n %}{% load staticfiles %}{% get_current_language as LANGUAGE_CODE %} +{% load i18n %}{% load static %}{% get_current_language as LANGUAGE_CODE %} diff --git a/cas_server/templates/cas_server/logout.html b/cas_server/templates/cas_server/logout.html index d8ab1dc..8069337 100644 --- a/cas_server/templates/cas_server/logout.html +++ b/cas_server/templates/cas_server/logout.html @@ -1,5 +1,5 @@ {% extends "cas_server/base.html" %} -{% load staticfiles %} +{% load static %} {% load i18n %} {% block content %} diff --git a/cas_server/templates/cas_server/warn.html b/cas_server/templates/cas_server/warn.html index a5d874e..4f80b15 100644 --- a/cas_server/templates/cas_server/warn.html +++ b/cas_server/templates/cas_server/warn.html @@ -1,5 +1,5 @@ {% extends "cas_server/base.html" %} -{% load staticfiles %} +{% load static %} {% load i18n %} {% block content %} From bd9aedd1b4cbde16076d6a18b149bd2031c5386d Mon Sep 17 00:00:00 2001 From: Valentin Samir Date: Sat, 2 Mar 2019 11:37:11 +0100 Subject: [PATCH 6/6] Update to version 1.1.0 --- CHANGELOG.rst | 4 ++-- cas_server/__init__.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 58312d6..8c4666a 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -6,8 +6,8 @@ All notable changes to this project will be documented in this file. .. contents:: Table of Contents :depth: 2 -Unreleased -========== +v1.1.0 - 2019-03-02 +=================== Added ----- diff --git a/cas_server/__init__.py b/cas_server/__init__.py index 1a50834..26a5bcd 100644 --- a/cas_server/__init__.py +++ b/cas_server/__init__.py @@ -11,7 +11,7 @@ """A django CAS server application""" #: version of the application -VERSION = '1.0.0' +VERSION = '1.1.0' #: path the the application configuration class default_app_config = 'cas_server.apps.CasAppConfig'