From c7171bb386a0db61bee1cf61f44dcb85c5e59487 Mon Sep 17 00:00:00 2001
From: Valentin Samir <valentin.samir@crans.org>
Date: Sat, 10 Sep 2016 15:24:30 +0200
Subject: [PATCH] Add a test for login with missing parameter (username or
 password or both)

---
 cas_server/tests/test_view.py | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/cas_server/tests/test_view.py b/cas_server/tests/test_view.py
index c623a27..22b3bd7 100644
--- a/cas_server/tests/test_view.py
+++ b/cas_server/tests/test_view.py
@@ -132,6 +132,37 @@ class LoginTestCase(TestCase, BaseServicePattern, CanLogin):
         # The LoginTicket is conssumed and should no longer be valid
         self.assertTrue(params['lt'] not in client.session['lt'])
 
+    def test_login_post_missing_params(self):
+        """Test a login attempt with missing POST parameters (username or password or both)"""
+        # we get a client who fetch a frist time the login page and the login form default
+        # parameters
+        client, params = get_login_page_params()
+        # we set only set username
+        params["username"] = settings.CAS_TEST_USER
+        # we post a login attempt
+        response = client.post('/login', params)
+        # as the LT is not valid, login should fail
+        self.assert_login_failed(client, response)
+
+        # we get a client who fetch a frist time the login page and the login form default
+        # parameters
+        client, params = get_login_page_params()
+        # we set only set password
+        params["password"] = settings.CAS_TEST_PASSWORD
+        # we post a login attempt
+        response = client.post('/login', params)
+        # as the LT is not valid, login should fail
+        self.assert_login_failed(client, response)
+
+        # we get a client who fetch a frist time the login page and the login form default
+        # parameters
+        client, params = get_login_page_params()
+        # we set neither username nor password
+        # we post a login attempt
+        response = client.post('/login', params)
+        # as the LT is not valid, login should fail
+        self.assert_login_failed(client, response)
+
     def test_login_view_post_goodpass_goodlt_warn(self):
         """Test a successul login requesting to be warned before creating services tickets"""
         # get a client and initial login params