Merge pull request #26 from JostCrow/master
Added a way to disable the service messages on the login page
This commit is contained in:
commit
253b431194
|
@ -218,7 +218,8 @@ Template settings
|
|||
}
|
||||
|
||||
if you omit some keys of the dictionnary, the default value for these keys is used.
|
||||
|
||||
* ``CAS_SHOW_SERVICE_MESSAGES``: Messages displayed about the state of the service on the login page.
|
||||
The default is ``True``.
|
||||
* ``CAS_INFO_MESSAGES``: Messages displayed in info-boxes on the html pages of the default templates.
|
||||
It is a dictionnary mapping message name to a message dict. A message dict has 3 keys:
|
||||
|
||||
|
|
|
@ -185,6 +185,8 @@ CAS_NEW_VERSION_EMAIL_WARNING = True
|
|||
#: You should not change it.
|
||||
CAS_NEW_VERSION_JSON_URL = "https://pypi.python.org/pypi/django-cas-server/json"
|
||||
|
||||
#: If the service message should be displayed on the login page
|
||||
CAS_SHOW_SERVICE_MESSAGES = True
|
||||
|
||||
#: Messages displayed in a info-box on the html pages of the default templates.
|
||||
#: ``CAS_INFO_MESSAGES`` is a :class:`dict` mapping message name to a message :class:`dict`.
|
||||
|
|
|
@ -295,6 +295,24 @@ class LoginTestCase(TestCase, BaseServicePattern, CanLogin):
|
|||
) in response.content
|
||||
)
|
||||
|
||||
@override_settings(CAS_SHOW_SERVICE_MESSAGES=False)
|
||||
def test_view_login_get_allowed_service_no_message(self):
|
||||
"""Request a ticket for an allowed service by an unauthenticated client"""
|
||||
# get a bare new http client
|
||||
client = Client()
|
||||
# we are not authenticated and are asking for a ticket for https://www.example.com
|
||||
# which is a valid service matched by self.service_pattern
|
||||
response = client.get("/login?service=https://www.example.com")
|
||||
# the login page should be displayed
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# we warn the user why it need to authenticated
|
||||
self.assertFalse(
|
||||
(
|
||||
b"Authentication required by service "
|
||||
b"example (https://www.example.com)"
|
||||
) in response.content
|
||||
)
|
||||
|
||||
def test_view_login_get_denied_service(self):
|
||||
"""Request a ticket for an denied service by an unauthenticated client"""
|
||||
# get a bare new http client
|
||||
|
@ -306,6 +324,18 @@ class LoginTestCase(TestCase, BaseServicePattern, CanLogin):
|
|||
# we warn the user that https://www.example.net is not an allowed service url
|
||||
self.assertTrue(b"Service https://www.example.net not allowed" in response.content)
|
||||
|
||||
@override_settings(CAS_SHOW_SERVICE_MESSAGES=False)
|
||||
def test_view_login_get_denied_service_no_message(self):
|
||||
"""Request a ticket for an denied service by an unauthenticated client"""
|
||||
# get a bare new http client
|
||||
client = Client()
|
||||
# we are not authenticated and are asking for a ticket for https://www.example.net
|
||||
# which is NOT a valid service
|
||||
response = client.get("/login?service=https://www.example.net")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
# we warn the user that https://www.example.net is not an allowed service url
|
||||
self.assertFalse(b"Service https://www.example.net not allowed" in response.content)
|
||||
|
||||
def test_view_login_get_auth_allowed_service(self):
|
||||
"""Request a ticket for an allowed service by an authenticated client"""
|
||||
# get a client that is already authenticated
|
||||
|
@ -505,6 +535,40 @@ class LoginTestCase(TestCase, BaseServicePattern, CanLogin):
|
|||
# renewing authentication is done in the validate and serviceValidate views tests
|
||||
self.assertEqual(ticket.renew, True)
|
||||
|
||||
@override_settings(CAS_SHOW_SERVICE_MESSAGES=False)
|
||||
def test_renew_message_disabled(self):
|
||||
"""test the authentication renewal request from a service"""
|
||||
# use the default test service
|
||||
service = "https://www.example.com"
|
||||
# get a client that is already authenticated
|
||||
client = get_auth_client()
|
||||
# ask for a ticket for the service but aks for authentication renewal
|
||||
response = client.get("/login", {'service': service, 'renew': 'on'})
|
||||
# we are ask to reauthenticate and tell the user why
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertFalse(
|
||||
(
|
||||
b"Authentication renewal required by "
|
||||
b"service example (https://www.example.com)"
|
||||
) in response.content
|
||||
)
|
||||
# get the form default parameter
|
||||
params = copy_form(response.context["form"])
|
||||
# set valid username/password
|
||||
params["username"] = settings.CAS_TEST_USER
|
||||
params["password"] = settings.CAS_TEST_PASSWORD
|
||||
# the renew parameter from the form should be True
|
||||
self.assertEqual(params["renew"], True)
|
||||
# post the authentication request
|
||||
response = client.post("/login", params)
|
||||
# the request succed, a ticket is created and we are redirected to the service url
|
||||
self.assertEqual(response.status_code, 302)
|
||||
ticket_value = response['Location'].split('ticket=')[-1]
|
||||
ticket = models.ServiceTicket.objects.get(value=ticket_value)
|
||||
# the created ticket is marked has being gottent after a renew. Futher testing about
|
||||
# renewing authentication is done in the validate and serviceValidate views tests
|
||||
self.assertEqual(ticket.renew, True)
|
||||
|
||||
@override_settings(CAS_ENABLE_AJAX_AUTH=True)
|
||||
def test_ajax_login_required(self):
|
||||
"""
|
||||
|
|
|
@ -835,26 +835,29 @@ class LoginView(View, LogoutMixin):
|
|||
# clean messages before leaving django
|
||||
list(messages.get_messages(self.request))
|
||||
return HttpResponseRedirect(self.service)
|
||||
if self.request.session.get("authenticated") and self.renew:
|
||||
messages.add_message(
|
||||
self.request,
|
||||
messages.WARNING,
|
||||
_(u"Authentication renewal required by service %(name)s (%(url)s).") %
|
||||
{'name': service_pattern.name, 'url': self.service}
|
||||
)
|
||||
else:
|
||||
messages.add_message(
|
||||
self.request,
|
||||
messages.WARNING,
|
||||
_(u"Authentication required by service %(name)s (%(url)s).") %
|
||||
{'name': service_pattern.name, 'url': self.service}
|
||||
)
|
||||
|
||||
if settings.CAS_SHOW_SERVICE_MESSAGES:
|
||||
if self.request.session.get("authenticated") and self.renew:
|
||||
messages.add_message(
|
||||
self.request,
|
||||
messages.WARNING,
|
||||
_(u"Authentication renewal required by service %(name)s (%(url)s).") %
|
||||
{'name': service_pattern.name, 'url': self.service}
|
||||
)
|
||||
else:
|
||||
messages.add_message(
|
||||
self.request,
|
||||
messages.WARNING,
|
||||
_(u"Authentication required by service %(name)s (%(url)s).") %
|
||||
{'name': service_pattern.name, 'url': self.service}
|
||||
)
|
||||
except ServicePattern.DoesNotExist:
|
||||
messages.add_message(
|
||||
self.request,
|
||||
messages.ERROR,
|
||||
_(u'Service %s not allowed') % self.service
|
||||
)
|
||||
if settings.CAS_SHOW_SERVICE_MESSAGES:
|
||||
messages.add_message(
|
||||
self.request,
|
||||
messages.ERROR,
|
||||
_(u'Service %s not allowed') % self.service
|
||||
)
|
||||
if self.ajax:
|
||||
data = {
|
||||
"status": "error",
|
||||
|
|
Loading…
Reference in New Issue